CITGM style ci for direct express deps #304

Activity

1. jonchurch

   added

   tc agenda

   on Nov 13, 2024
2. jonchurch commented on Nov 13, 2024

   

   jonchurch

   on Nov 13, 2024

   Last edited by jonchurch

   MemberAuthor

   More actions

   havent tested this yet

   name: Express Dependency Monitor (EDM)
   
   on:
     push:
       branches: [ main ]
     pull_request:
       branches: [ main ]
   
   jobs:
     test-express-with-local-package:
       runs-on: ubuntu-latest
       continue-on-error: true  # Allows the workflow to continue even if this job fails
   
       steps:
       - name: Checkout code
         uses: actions/checkout@v3
   
       - name: Set up Node.js
         uses: actions/setup-node@v3
         with:
           node-version: '18'
   
       - name: Install dependencies
         run: npm install
   
       - name: Build package
         run: npm run build --if-present
   
       - name: Pack local package
         run: npm pack
         shell: bash
   
       - name: Store package file name
         id: packfile
         run: |
           package_name=$(jq -r .name package.json | sed 's/@//; s/\//-/')
           package_version=$(jq -r .version package.json)
           echo "packfile_name=${package_name}-${package_version}.tgz" >> $GITHUB_OUTPUT
         shell: bash
   
       - name: Clone Express.js
         run: git clone --depth 1 https://github.com/expressjs/express.git
   
       - name: Install Express.js dependencies
         run: |
           cd express
           npm install
   
       - name: Install local package into Express.js
         run: |
           cd express
           npm install ../${{ steps.packfile.outputs.packfile_name }}
   
       - name: Run Express.js tests
         run: |
           cd express
           npm test
   
   
3. ljharb commented on Nov 13, 2024

   

   ljharb

   on Nov 13, 2024

   Last edited by ljharb

   Contributor

   More actions

   see also https://npmjs.com/wiby

   👍React with 👍1Reacted by Wes Todd

   👀React with 👀2Reacted by Jon Church and Sebastian Beltran
4. UlisesGascon commented on Nov 14, 2024

   

   UlisesGascon

   on Nov 14, 2024

   Member

   More actions

   I love this idea a lot!

   CITGM is currently a challenge when we do releases in Node. This will helps us to anticipate issues ahead of releases ❤️.

   Aside of targeting commits from our side on > push. I will suggest to trigger this workflow based on cron jobs so we can test this against the last canary release available, etc... Otherwise our anticipation will be very limited.

   Obviously we can add some notifications (issues) in case that the actual tests fails and not due binaries availability.

   cc:@marco-ippolito and @RafaelGSS for sure they can add much more context and ideas here 👍

   👍React with 👍2Reacted by Marco Ippolito and Wes Todd
5. bjohansebas

   added

   discuss

   top priorityIssues which the TC deem our current highest priorities for the projectIssues which the TC deem our current highest priorities for the project

   on Jan 28, 2025
6. bjohansebas commented on Mar 3, 2025

   

   bjohansebas

   on Mar 3, 2025

   Last edited by bjohansebas

   Member

   More actions

   How WIBY works right now, I don't think it's ideal for Express, since we would have to create a GitHub token between the repositories with write permissions. I am working to make this unnecessary, which is something I will be working on these months (see pkgjs/wiby#154).

   Here's an example of how it works right now (bjohansebas/body-parser#1, bjohansebas/express#1).
7. bjohansebas

   removed

   tc agenda

   on Mar 3, 2025
8. bjohansebas

   removed

   top priorityIssues which the TC deem our current highest priorities for the projectIssues which the TC deem our current highest priorities for the project

   on Jul 2, 2025
9. bjohansebas commented on Jul 3, 2025

   

   bjohansebas

   on Jul 3, 2025

   Member

   More actions

   In about two weeks I'm going on vacation, so I'll be able to dedicate some time to this.