Skip to content

app.set() JSON style #3997

Closed
Closed

Description

@knoxcard

Why cant I do this?

app.set({
  'view engine': 'hbs',
  'colors': require('chalk'),
  'functions': require('./lib/functions')(app)
})

instead of doing this?

app.set('view engine', 'hbs')
app.set('colors', require('chalk'))
app.set('functions', require('./lib/functions')(app))

Activity

  1. wesleytodd commented on Jul 1, 2019

    @wesleytodd
    Member

    See #3218, #3714 & https://github.com/wesleytodd/store-settings

    I think this would be a good addition to that module, then could land in either 5 or 6. I feel like there was another discussion about this, but I could not find it. If I were you I would submit a pr to add that on that repo so when we merge those pr's we will just get the new functionality.

  2. knoxcard commented on Jul 1, 2019

    @knoxcard
    Author
  3. ahmedHusseinF commented on Aug 29, 2019

    @ahmedHusseinF

    I am new to open source, and this looks like an easy feature, so I will try to submit a pr for this.

  4. davidmashe commented on Apr 10, 2020

    @davidmashe

    one related PR is closed, other is stale. Closing issue, can re-open if PR gets activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions