fix(frontend): clear the high-severity advisories blocking every PR - #444
Merged
Merged
Conversation
`npm audit --audit-level=high` in frontend/ started failing after the last green run on main, blocking the required Frontend audit check on every open pull request. Three advisories, all fixable within the existing semver ranges, so package.json is untouched and only the lockfile moves: - dompurify 3.4.13 -> 3.4.16 (high, GHSA-p98j-92pf-mc4p): with IN_PLACE, a node-removing afterSanitize hook left event handlers armed on the detached subtree, giving DOM XSS. This is the one that actually matters here, since dompurify is a direct dependency and ships in the vendor bundle. - brace-expansion 1.1.20 -> 1.1.21 (high, GHSA-q2hr-2g5m-vwhr, GHSA-qhr7-859c-m2p7, GHSA-6j4f-fj2g-mc7p): three denial-of-service paths, transitive and build-time only. - fast-uri 3.1.7 -> 3.1.8 (moderate, GHSA-hrr3-gc8f-f4qj): inconsistent host case normalization. Below the gate's threshold, but it came along with the same fix. public/assets/vendor.bundle.js is regenerated because dompurify is bundled into it; no other built asset changes. Verified: npm audit reports 0 vulnerabilities, eslint is clean, and two consecutive production builds produce a byte-identical vendor.bundle.js, so the double-build reproducibility check stays satisfied.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⛔ Files ignored due to path filters (1)
⚙️ Run configurationConfiguration used: Repository: fabiodalez-dev/Pinakes/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fabiodalez-dev
added a commit
that referenced
this pull request
Oct 1, 2026
main now ships the same DOMPurify, fast-uri and brace-expansion versions (#444), resolved identically; only the declared DOMPurify range differed. Matching main keeps this branch's diff to its own change.
fabiodalez-dev
added a commit
that referenced
this pull request
Oct 1, 2026
main now ships the same DOMPurify, fast-uri and brace-expansion versions (#444), resolved identically; only the declared DOMPurify range differed. Matching main keeps this branch's diff to its own change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm audit --audit-level=highinfrontend/began failing after the last green run onmain, which blocks the required Frontend audit, lint and reproducible build check on every open pull request.mainitself is green only because it was last audited on 29 September, before these advisories were published.Three advisories, all fixable inside the existing semver ranges, so
package.jsonis untouched and only the lockfile moves:dompurifybrace-expansionfast-uriThe DOMPurify one is the only one with real exposure here: it is a direct dependency and ships inside the vendor bundle. With
IN_PLACE, a node-removingafterSanitizehook left event handlers armed on the detached subtree, which gives DOM XSS. The other two are denial-of-service paths in build-time transitive packages.public/assets/vendor.bundle.jsis regenerated because DOMPurify is bundled into it. No other built asset changes.Verified before pushing
npm audit --audit-level=highinfrontend/: 0 vulnerabilities (was 1 high, 1 moderate, 1 low).npm run lint: clean.npm run buildruns produce a byte-identicalvendor.bundle.js(129bdeca…3d7222), so the double-build reproducibility check stays satisfied.