Skip to content

fix(core): use locale url in site config #12054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slorber merged 2 commits into from
May 22, 2026
Merged

fix(core): use locale url in site config #12054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32ca03b
fix(core): use locale url in site config
rohan-patnaik May 22, 2026
aa61727
test(core): update locale url snapshots
rohan-patnaik May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/docusaurus/src/server/__tests__/__snapshots__/site.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1844,7 +1844,7 @@ exports[`loadSite > simple-site-with-baseUrl-i18n > loads site - locale es 1`] =
"themes": [],
"title": "Hello",
"titleDelimiter": "|",
"url": "https://docusaurus.io",
"url": "https://es.docusaurus.io",
},
"siteConfigPath": "<PROJECT_ROOT>/packages/docusaurus/src/server/__tests__/__fixtures__/loadSiteFixtures/simple-site-with-baseUrl-i18n/docusaurus.config.js",
"siteDir": "<PROJECT_ROOT>/packages/docusaurus/src/server/__tests__/__fixtures__/loadSiteFixtures/simple-site-with-baseUrl-i18n",
Expand Down Expand Up @@ -2312,7 +2312,7 @@ exports[`loadSite > simple-site-with-baseUrl-i18n > loads site - locale it 1`] =
"themes": [],
"title": "Hello",
"titleDelimiter": "|",
"url": "https://docusaurus.io",
"url": "https://it.docusaurus.io",
},
"siteConfigPath": "<PROJECT_ROOT>/packages/docusaurus/src/server/__tests__/__fixtures__/loadSiteFixtures/simple-site-with-baseUrl-i18n/docusaurus.config.js",
"siteDir": "<PROJECT_ROOT>/packages/docusaurus/src/server/__tests__/__fixtures__/loadSiteFixtures/simple-site-with-baseUrl-i18n",
Expand Down
7 changes: 7 additions & 0 deletions packages/docusaurus/src/server/__tests__/site.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,13 @@ describe('loadSite', () => {
expect(site.props).toMatchSnapshot();
});

it('uses locale url in site config', async () => {
const site = await loadSiteFixture(siteFixture, {
locale: 'es',
});
expect(site.props.siteConfig.url).toBe('https://es.docusaurus.io');
});

it('loads site - locale de', async () => {
const site = await loadSiteFixture(siteFixture, {
locale: 'de',
Expand Down
1 change: 1 addition & 0 deletions packages/docusaurus/src/server/site.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ export async function loadContext(

const siteConfig: DocusaurusConfig = {
...initialSiteConfig,
url: localeConfig.url,
baseUrl,
};

Expand Down
Loading