Skip to content

build(deps-dev): bump the vitest group across 1 directory with 2 updates - #9157

Merged
etrepum merged 4 commits into
mainfrom
dependabot/npm_and_yarn/vitest-f0fe82b5e0
Sep 17, 2026
Merged

etrepum merged 4 commits into
mainfrom
dependabot/npm_and_yarn/vitest-f0fe82b5e0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 11, 2026

Copy link
Copy Markdown
Contributor

Bumps the vitest group with 2 updates in the / directory: @vitest/browser-playwright and vitest.

Updates @vitest/browser-playwright from 4.1.11 to 5.0.0

Release notes

Sourced from @​vitest/browser-playwright's releases.

v5.0.0

Vitest 5 is officially out! This release focuses on performance and brings a lot of new features while fixing long-standing bugs. See our blog post for the official announcement.

   🚨 Breaking Changes

... (truncated)

Commits

Updates vitest from 4.1.11 to 5.0.0

Release notes

Sourced from vitest's releases.

v5.0.0

Vitest 5 is officially out! This release focuses on performance and brings a lot of new features while fixing long-standing bugs. See our blog post for the official announcement.

   🚨 Breaking Changes

... (truncated)

Commits
  • f441c6f chore: release v5.0.0 (#11130)
  • d46a747 fix: treat test.describe as a suite during static collection (#11128)
  • 584cf30 fix: add a warning if inline project has duplicate plugins due to unexpected ...
  • f08ce4b fix: apply queued mocks from doMock() in queue order (fixes #10706) (#11127)
  • 897f51f chore: release v5.0.0-rc.4 (#11107)
  • 1339b06 chore(deps): update all non-major dependencies (#11104)
  • 51e9494 feat!: parse files statically in vitest list by default (#11088)
  • 2122ffd fix: propagate --maxWorkers to projects (#11102)
  • dc10f5f fix(browser): report the action error when a task times out (#11101)
  • d4fe198 feat: promote clearCache out of experimental (#11086)
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 11, 2026
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 11, 2026
@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
lexical Ready Ready Preview Sep 17, 2026 12:36am UTC
lexical-playground Ready Ready Preview Sep 17, 2026 12:36am UTC

Request Review

Bumps the vitest group with 2 updates in the / directory: [@vitest/browser-playwright](https://github.com/vitest-dev/vitest/tree/HEAD/packages/browser-playwright) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest).


Updates `@vitest/browser-playwright` from 4.1.11 to 5.0.0
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md)
- [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.0/packages/browser-playwright)

Updates `vitest` from 4.1.11 to 5.0.0
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md)
- [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.0/packages/vitest)

---
updated-dependencies:
- dependency-name: "@vitest/browser-playwright"
  dependency-version: 5.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: vitest
- dependency-name: vitest
  dependency-version: 5.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: vitest
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/vitest-f0fe82b5e0 branch from 5a11f5e to 1f424f8 Compare September 16, 2026 22:28
etrepum added a commit to etrepum/lexical that referenced this pull request Sep 16, 2026
…pter

## Description

The initial fix for facebook#9157 duplicated the toHaveNoViolations assertion signature. Import the matcher object type from jest-axe and use its keys to select the existing signatures from jest.Matchers<R> instead.

A Vitest module augmentation is still necessary because @types/jest-axe only augments Jest. The adapter now reuses the upstream assertion signatures and return types without importing unrelated Jest matchers.

## Test plan

### Before

The original PR, before the stacked fix, failed `pnpm run tsc` with status 2:

```text
packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx(244,21): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx(295,21): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(607,33): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(647,35): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(765,33): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(805,35): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
```

The initial adapter passed these checks but manually repeated the matcher signature.

### After

`pnpm run ci-check` passed with status 0:

```text
$ npm-run-all --parallel tsc tsc-scripts tsc-extension tsc-website flow prettier lint
$ tsc
$ tsc -p ./tsconfig.scripts.json
$ pnpm --filter @lexical/devtools run compile
$ prettier --list-different .
$ node ./scripts/check-flow-types.mjs
$ pnpm --filter @lexical/website run tsc
$ eslint ./
Running Flow...
$ tsc -p tsconfig.json
$ tsc --noEmit
Found 0 errors
```

An isolated TypeScript compiler API probe also passed:

```text
Matcher declarations pass with skipLibCheck=false; direct/not return void, resolves/rejects return Promise<void>, unknown matchers remain errors.
Matcher keys and signatures match jest-axe types exactly.
```

Validated on Linux with Node 24.19.0 and Vitest 5.0.0. Runtime tests and browser/platform matrices were not rerun for this type-only refinement; the prior revision passed all 27 tests across the three relevant suites.
## Description

Vitest 5 no longer inherits the global Jest matcher declarations from @types/jest-axe, so the accessibility assertions fail TypeScript checking even though the tests pass at runtime.

Augment Vitest's Matchers interface in a declaration scoped to the React test utilities. Preserve the return type for direct and resolves/rejects assertions. The declaration is excluded from published type builds with the other test files.

This commit is stacked directly on #9157 at 5a11f5e.

## Test plan

### Before

`pnpm run tsc` exited with status 2:

```text
packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx(244,21): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx(295,21): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(607,33): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(647,35): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(765,33): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(805,35): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
```

### After

`pnpm run ci-check` exited with status 0:

```text
$ npm-run-all --parallel tsc tsc-scripts tsc-extension tsc-website flow prettier lint
$ node ./scripts/check-flow-types.mjs
$ prettier --list-different .
$ tsc -p ./tsconfig.scripts.json
$ pnpm --filter @lexical/devtools run compile
$ eslint ./
$ tsc
Running Flow...
$ pnpm --filter @lexical/website run tsc
$ tsc --noEmit
$ tsc -p tsconfig.json
Found 0 errors
```

`pnpm run test-unit --maxWorkers=2 LexicalContentEditableElement LexicalNestedComposer LexicalExtensionEditorComposer` exited with status 0:

```text
 Test Files  3 passed (3)
      Tests  27 passed (27)
```

An isolated TypeScript compiler API probe with `skipLibCheck: false` also passed:

```text
Matcher declarations pass with skipLibCheck=false; direct/not return void, resolves/rejects return Promise<void>, unknown matchers remain errors.
```

Validated on Linux with Node 24.19.0 and Vitest 5.0.0. Browser and other platform suites were not rerun; this change only adds a test type declaration.
…pter

## Description

The initial fix for #9157 duplicated the toHaveNoViolations assertion signature. Import the matcher object type from jest-axe and use its keys to select the existing signatures from jest.Matchers<R> instead.

A Vitest module augmentation is still necessary because @types/jest-axe only augments Jest. The adapter now reuses the upstream assertion signatures and return types without importing unrelated Jest matchers.

## Test plan

### Before

The original PR, before the stacked fix, failed `pnpm run tsc` with status 2:

```text
packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx(244,21): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx(295,21): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(607,33): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(647,35): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(765,33): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
packages/lexical-react/src/__tests__/unit/LexicalNestedComposer.test.tsx(805,35): error TS2339: Property 'toHaveNoViolations' does not exist on type 'Assertion<void, AxeResults>'.
```

The initial adapter passed these checks but manually repeated the matcher signature.

### After

`pnpm run ci-check` passed with status 0:

```text
$ npm-run-all --parallel tsc tsc-scripts tsc-extension tsc-website flow prettier lint
$ tsc
$ tsc -p ./tsconfig.scripts.json
$ pnpm --filter @lexical/devtools run compile
$ prettier --list-different .
$ node ./scripts/check-flow-types.mjs
$ pnpm --filter @lexical/website run tsc
$ eslint ./
Running Flow...
$ tsc -p tsconfig.json
$ tsc --noEmit
Found 0 errors
```

An isolated TypeScript compiler API probe also passed:

```text
Matcher declarations pass with skipLibCheck=false; direct/not return void, resolves/rejects return Promise<void>, unknown matchers remain errors.
Matcher keys and signatures match jest-axe types exactly.
```

Validated on Linux with Node 24.19.0 and Vitest 5.0.0. Runtime tests and browser/platform matrices were not rerun for this type-only refinement; the prior revision passed all 27 tests across the three relevant suites.
@etrepum
etrepum added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit 4973ca1 Sep 17, 2026
50 checks passed
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/vitest-f0fe82b5e0 branch September 17, 2026 01:26
@etrepum etrepum mentioned this pull request Sep 17, 2026

This branch was successfully deployed

2 active deployments
Preview – lexical a0e1a0e6 Deployed Sep 17, 2026 by vercel[bot]
Preview – lexical-playground a0e1a0e6 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant