[lexical] Bug Fix: Avoid redundant selection change command - #9163
Merged
Merged
Conversation
levensta
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon and
zurfyx
as code owners
September 13, 2026 00:26
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
levensta
changed the title
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
etrepum
approved these changes
Sep 13, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on the patch from #9138
Explicit conditions have been added for the
SELECTION_CHANGE_COMMANDdispatcher to prevent false triggers, such as when a user interacts with the interface outside the editor (for example, by clicking a link in a floating toolbar).Closes #8885
Test plan
Before
Safari generates a
selectionchangeevent when you click on buttons that contain text, and the lexical dispatcher dispatchesSELECTION_CHANGE_COMMANDsafari-selectionchange.mov
After
Changing the selection on text outside the editor no longer triggers SELECTION_CHANGE_COMMAND. A browser test has been added
Screen.Recording.2026-09-13.at.02.54.37.mov