feat(mod-loaders): complete neoforge for 26.x, drop forge/quilt, fix fabric metrics#179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #174, opening a new PR since edits are not possible, also targeting main now
What this does
Builds on PR #168 to make NeoForge fully functional on Minecraft 26.x, removes Forge and Quilt, and fixes a Fabric client-lifecycle bug. Targets
feat/more-mod-loaders.NeoForge
Switches the module from the loader-only stub to ModDevGradle (
net.neoforged.moddev) against NeoForge26.1.2.76, which puts Minecraft on the compile classpath.minecraft_version,platform_version,player_count,online_mode.NeoForgeMetricsClient/NeoForgeMetricsServer), selected by physical side viaFMLEnvironment.getDist().ready()/shutdown()wired toServerStartedEvent/ServerStoppingEvent; the client relies on the periodic submitter, since NeoForge has no client-stop event.getModContainerById) and server-reference capture (onServerStartedEvent), mirroring the Fabric module's patterns.Forge and Quilt (removed)
The FastStats SDK build is a single Gradle 9 toolchain (Fabric needs Loom 1.15, NeoForge needs ModDevGradle), and a Gradle build has one wrapper version.
net.minecraftforge:forgeup to26.1.2-64.0.x), but modern Forge builds only with ForgeGradle (ModDevGradle'slegacyforgeplugin stops at 1.20.1), and the latest ForgeGradle (6.0.54) does not support Gradle 9 ("Versions Gradle 9.0 and newer are not supported yet"). Since it cannot run alongside the Gradle 9 toolchain Fabric and NeoForge require, Forge cannot be included here. It can return once ForgeGradle adds Gradle 9 support, or on a separate Gradle 8 build.quilt-mappingsstop at1.21.11), so there is nothing to build against yet.Fabric
CLIENT_STARTEDinstead ofCLIENT_STOPPING(they stopped immediately after startup).platform_version(the Fabric loader version) so Fabric and NeoForge report a consistent default schema.Verification
fabricandneoforgelibrary jars and the NeoForge example-mod jar all build, and core tests pass.For review
platform_versionis a new default field per Add Quilt and Forge Support #168 TODOs. Just need to ensure backend accepts and records it for both loaders.Bumps version to
0.26.2.