Skip to content

handle testify output - #1637

Closed
bhcleek wants to merge 1 commit into
fatih:masterfrom
bhcleek:handle-testify-output
Closed

bhcleek wants to merge 1 commit into
fatih:masterfrom
bhcleek:handle-testify-output

Conversation

@bhcleek

@bhcleek bhcleek commented Jan 4, 2018

Copy link
Copy Markdown
Collaborator

I'm not sure if we want to do this or not, but the fix was relatively simple... testify is its own beast, though, and I'm reluctant to add official support for it.

Fixes #1636

@fatih

fatih commented Jan 4, 2018

Copy link
Copy Markdown
Owner

This came up before and I've said 👎 Reason is that maintaining third party compatibility is not worth it. We should aim to support for Go only. This should go into a plugin called vim-go-testify or something alike. We use third party tools, but those provide a feature that we control, here someone decides to use on their own and we're trying to fix it. There was also another PR that would add support for a third party templating library, but I've also rejected that as well due the same reason.

I know you want to be helpful, but this is not what vim-go should do going forward.

@bhcleek bhcleek closed this Jan 4, 2018
@bhcleek
bhcleek deleted the handle-testify-output branch January 4, 2018 15:43
@ernesto-jimenez

Copy link
Copy Markdown

I believe this should address the issue: stretchr/testify#554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

let g:go_jump_to_error = 0 does not prevent new buffer from opening when using 3rd party testing packages

3 participants