Skip to content

Update typehints to allow usage of latest mypy version #4

Description

@max-k

Checklist

  • I have updated signatures to match parents classes
  • I have sucessfuly run mypy 0.790 using mypy -m mode
  • I have updated requirements/typecheck.txt to remove mention to explicit mypy version

Steps to reproduce

Using latest mypy version, typehint checks are broken

Expected behavior

$ mypy -p mode
Success: no issues found in 46 source files

Actual behavior

$ mypy -p mode
mode/locals.py: note: In member "throw" of class "CoroutineRole":
mode/locals.py:424:5: error: Signature of "throw" incompatible with supertype "Coroutine"  [override]
        def throw(self,
        ^
mode/locals.py: note: In member "athrow" of class "AsyncGeneratorRole":
mode/locals.py:487:5: error: Signature of "athrow" incompatible with supertype "AsyncGenerator"  [override]
        def athrow(self,
        ^
mode/locals.py: note: In member "index" of class "SequenceRole":
mode/locals.py:523:5: error: Signature of "index" incompatible with supertype "Sequence"  [override]
        def index(self, x: Any, *args: Any, **kwargs: Any) -> int:
        ^
mode/utils/imports.py: note: In member "by_url" of class "FactoryMapping":
mode/utils/imports.py:98:5: error: Argument 2 to "by_url" becomes "Union[str, Any]" due to an unfollowed import  [no-any-unimported]
        def by_url(self, url: Union[str, URL]) -> _T:
        ^
Found 4 errors in 2 files (checked 46 source files)

Versions

  • Python 3.9
  • Mode 0.1.0
  • Mypy 0.790

Additional informations

Typehints of parent classes can be found in typeshed github project.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions