Skip to content

fix(dash0): accept multiple DNS expected IPs/values via chip input - #161

Merged
fclairamb merged 2 commits into
mainfrom
fix/dns-expected-ips-chip-input
Jul 21, 2026
Merged

fclairamb merged 2 commits into
mainfrom
fix/dns-expected-ips-chip-input

Conversation

@fclairamb

Copy link
Copy Markdown
Owner

Summary

  • The DNS check form had no way to assert on what a lookup actually resolved to — it could only confirm the lookup succeeded, even though the backend has long supported expected_ips (A/AAAA) and expected_values (CNAME/MX/NS/TXT).
  • A/AAAA record types now get an "Expected IPs" chip input, validated as IPv4/IPv6 respectively — invalid entries render as a destructive chip and block save.
  • Every other record type gets an "Expected values" textarea (one entry per line) — a textarea rather than chips because TXT values legitimately contain spaces (e.g. SPF records) that a chip input would split on.
  • Leaving the field empty preserves today's behavior (only require a successful resolution). Switching record type always writes only the matching config key, never both — the backend rejects a config carrying both expected_ips and expected_values.

BREAKING CHANGE: none.

Test plan

  • make build-dash0 clean
  • bun run lint unchanged at the pre-existing 45-error baseline (only pre-existing-pattern warnings in the touched file, no new errors)
  • Frontend unit tests (vitest): fromConfig/toConfig seeding and serialization (IP vs values, mutual exclusivity, empty-omission, round-trip), plus IPv4/IPv6 validator edge cases — 11/11 passing

@fclairamb
fclairamb enabled auto-merge (squash) July 21, 2026 20:56
@fclairamb
fclairamb merged commit d91e60b into main Jul 21, 2026
11 checks passed
@fclairamb
fclairamb deleted the fix/dns-expected-ips-chip-input branch July 21, 2026 21:15
@fclairamb fclairamb mentioned this pull request Jul 21, 2026
fclairamb added a commit that referenced this pull request Jul 21, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.6.2](v0.6.1...v0.6.2)
(2026-07-21)


### Bug Fixes

* **dash0:** accept multiple DNS expected IPs/values via chip input
([#161](#161))
([d91e60b](d91e60b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant