Skip to content

fix: name the license file LICENSE so pkg.go.dev detects it - #272

Merged
fclairamb merged 1 commit into
mainfrom
fix/license-file-name
Aug 27, 2026
Merged

fclairamb merged 1 commit into
mainfrom
fix/license-file-name

Conversation

@fclairamb

Copy link
Copy Markdown
Owner

The server Go module lives in a subdirectory, and the go command only copies a repo-root license into a nested module's zip when the file is named exactly LICENSE (cmd/go/internal/modfetch/coderepo.go). With LICENSE.md, the published module zip for github.com/fclairamb/solidping/server carried no license file at all — verified against the proxy.golang.org zip — so pkg.go.dev detected no license and hid the docs.

Renaming to LICENSE fixes detection for every version published after this lands. GitHub's own license detection accepts either name.

🤖 Generated with Claude Code

The server Go module lives in a subdirectory, and the go command only
copies a repo-root license into a nested module's zip when the file is
named exactly LICENSE (cmd/go/internal/modfetch/coderepo.go). With
LICENSE.md the published module zip carried no license at all, so
pkg.go.dev showed no detected license and hid the documentation.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@fclairamb
fclairamb enabled auto-merge (squash) August 27, 2026 15:11
@fclairamb
fclairamb merged commit f11d7b6 into main Aug 27, 2026
11 checks passed
@fclairamb
fclairamb deleted the fix/license-file-name branch August 27, 2026 15:42
fclairamb added a commit that referenced this pull request Aug 28, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.19.1](v0.19.0...v0.19.1)
(2026-08-28)


### Bug Fixes

* **config:** bind SP_ENCRYPTION_MASTER_KEY so credentials stop being
stored in plaintext
([#276](#276))
([15615ad](15615ad))
* **deps:** update github.com/dop251/goja digest to 8f1c069
([#275](#275))
([550ed79](550ed79))
* **email:** link the check page in incident emails instead of the down
host ([#274](#274))
([0daaf40](0daaf40))
* name the license file LICENSE so pkg.go.dev detects it
([#272](#272))
([f11d7b6](f11d7b6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant