Skip to content

fix(auth,web): convert Auth errors that omit customData without throwing - #18686

Merged
Lyokone merged 2 commits into
mainfrom
auth_18680
Sep 14, 2026
Merged

Lyokone merged 2 commits into
mainfrom
auth_18680

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

On Flutter web, some Firebase Auth JS errors omit customData. getFirebaseAuthException cast that missing value to AuthErrorCustomData, which threw a TypeError after the app had already handled the sign-in failure.

This treats customData as nullable and still maps code / message (and email/phone/tenant when present) into FirebaseAuthException.

Related Issues

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

JS Auth errors sometimes omit customData, which caused a TypeError in
getFirebaseAuthException after the sign-in failure was already handled.

Fixes #18680
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@Lyokone
Lyokone merged commit 5e51836 into main Sep 14, 2026
116 of 117 checks passed
@Lyokone
Lyokone deleted the auth_18680 branch September 14, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_auth_web] Uncaught TypeError after showing INVALID_LOGIN_CREDENTIALS error (web_utils.dart getFirebaseAuthException)

3 participants