Repository navigation
fix(auth,web): convert Auth errors that omit customData without throwing - #18686
Conversation
JS Auth errors sometimes omit customData, which caused a TypeError in getFirebaseAuthException after the sign-in failure was already handled. Fixes #18680
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Description
On Flutter web, some Firebase Auth JS errors omit
customData.getFirebaseAuthExceptioncast that missing value toAuthErrorCustomData, which threw aTypeErrorafter the app had already handled the sign-in failure.This treats
customDataas nullable and still mapscode/message(and email/phone/tenant when present) intoFirebaseAuthException.Related Issues
Checklist
///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?