Skip to content

fix(firebase_ai): parse camelCase fileData response parts #18754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cabljac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(firebase_ai): parse camelCase fileData response parts #18754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/firebase_ai/firebase_ai/lib/src/content.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,12 @@ Part parsePart(Object? jsonObject) {
return switch (jsonObject) {
{'text': final String text} => TextPart._(text,
isThought: isThought, thoughtSignature: thoughtSignature),
{
'fileData': {
'fileUri': final String fileUri,
'mimeType': final String mimeType,
}
} ||
{
'file_data': {
'file_uri': final String fileUri,
Expand Down
47 changes: 47 additions & 0 deletions packages/firebase_ai/firebase_ai/test/content_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,53 @@ void main() {
expect(fileData.mimeType, 'text/plain');
});

test('parses camelCase fileData correctly', () {
final json = {
'fileData': {
'fileUri': 'gs://bucket/image.png',
'mimeType': 'image/png',
}
};
final result = parsePart(json);
expect(result, isA<FileData>());
final fileData = result as FileData;
expect(fileData.fileUri, 'gs://bucket/image.png');
expect(fileData.mimeType, 'image/png');
expect(fileData.isThought, false);
expect((fileData.toJson() as Map).containsKey('thoughtSignature'), false);
});

test('parses camelCase fileData with thought and thoughtSignature', () {
final json = {
'thought': true,
'thoughtSignature': 'sig',
'fileData': {
'fileUri': 'gs://bucket/image.png',
'mimeType': 'image/png',
}
};
final result = parsePart(json);
expect(result, isA<FileData>());
final fileData = result as FileData;
expect(fileData.fileUri, 'gs://bucket/image.png');
expect(fileData.mimeType, 'image/png');
expect(fileData.isThought, true);
expect((fileData.toJson() as Map)['thoughtSignature'], 'sig');
});

test('parses camelCase fileData with mediaResolution', () {
final json = {
'fileData': {
'fileUri': 'gs://bucket/image.png',
'mimeType': 'image/png',
},
'mediaResolution': {'level': 'MEDIA_RESOLUTION_HIGH'},
};
final result = parsePart(json);
expect(result, isA<FileData>());
expect((result as FileData).mediaResolution, MediaResolution.high);
});

test('parses InlineDataPart correctly', () {
final json = {
'inlineData': {
Expand Down
Loading