Repository navigation
chore(fork): drop the streamed-write-timestamps patch - #178
Merged
fireboltdude1357 merged 1 commit intoNov 3, 2026
Merged
Conversation
Upstream pingdotgg#25252 made the same change, so merging the patch on top declared encodePayloadTimestamp twice and broke both build legs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork's nightly build fails at 21:31 on upstream 61c3794. Both the Linux and Mac legs stop on a parse error:
Upstream pingdotgg#25252 makes the same change as
patch/streamed-write-timestamps. Message and turn-item writes now encode their timestamps directly instead of parsing the payload JSON back, and only the comment differs from the patch. It declaresencodePayloadTimestampin a different spot than the patch does, so git merges both copies without a conflict. The patch's own upstream PR, pingdotgg#25162, was closed.The doc says to delete a patch's line once it merges upstream, so this removes
streamed-write-timestampsfrom.github/fork-patches.txt. The branch stays.On a scratch stack of upstream 61c3794 with the other 21 patches, the merge is clean and
ProjectionStore.tsdeclaresencodePayloadTimestamponce.pnpm install --no-frozen-lockfile,vp run typecheck(40 of 40) andvp test runonProjectionStore.test.ts(53 tests, including upstream's new ones) pass.Made by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code