Restart fails with 6.7.8

[rmcdermo]

This issue was reported by Darko Perovic at CERN. The attached case crashes on restart with latest source, Linux OpenMP version. I'm testing now with other versions.

One_mesh_restart.fds.txt

[mcgratta]

This appears to be related to the output "clocks". I have identified the problem line.

[mcgratta]

I figured out the problem. FDS has a "feature" where it guarantees that all devices, clocks, timers, etc, that are given a specified DT_XXX for which T_END is not divisible are called one last time at the last time step. In this case, DT_RESTART=15 and T_END=29, which means that FDS wrote a restart file at 15 and 29 s. Upon restart, the initial T was the same as T_END, which caused a seg fault. I have to decide whether to keep this "feature" of DT_XXX and if I do, make DT_RESTART behave differently. I think we want to write a restart file only when the user wants it.

[drjfloyd]

I agree that for restart files it doesn't make sense to write the final file at T_END unless DT_RESTART evenly divides T_END (this way we write a file for the case where a user is running FDS just to get a restart and the end).

[mcgratta]

I'll make an exception to the rule for restart and any other "clock" for which we don't want this to occur.

[mcgratta]

I fixed the problem. FDS only dumps a RESTART file when the user wants it, and not also at the end of the run.