FDS 6.11.1_SMV-6.11.2: FDS6VARS.sh on macOS

[gjaeger]

FDS6VARS.sh (part of the macOS release bundle under /Applications/FDS/FDS6/bin/) uses the == comparison operator inside single square brackets ([ "$PATH" == "" ]) in its if conditions. This is not POSIX-compliant syntax for the test command (only a single = is valid there). While bash silently accepts this as an extension, sourcing the script under zsh fails, because zsh tries to resolve the second = via its EQUALS expansion and cannot find a matching command.

Steps to reproduce the behavior:

1. Install FDS6 on macOS (installation path: /Applications/FDS/FDS6/)
2. Use zsh as the default shell
3. Add/execute the following line in .zprofile: source /Applications/FDS/FDS6/bin/FDS6VARS.sh
4. Restart the terminal or run source .zprofile
5. The following error appears: /Applications/FDS/FDS6/bin/FDS6VARS.sh:3: = not found

Expected behavior
The script should run without errors and correctly set the environment variables (PATH, DYLD_LIBRARY_PATH, OPAL_PREFIX, TMPDIR, OMP_NUM_THREADS), regardless of whether it is sourced with bash or zsh.

Desktop

• OS: macOS Tahoe 26.5.2
• Version: FDS 6.11.1_SMV-6.11.2

Suggested fix for FDS6VARS.sh:

#!/bin/bash
FDSBINDIR=/Applications/FDS/FDS6/bin
if [ "$PATH" = "" ]; then
  export PATH=$FDSBINDIR
else
  export PATH=$FDSBINDIR:$PATH
fi
export PATH=$FDSBINDIR/openmpi/bin:$PATH
export OPAL_PREFIX=$FDSBINDIR/openmpi  # used when running the bundled fds
if [ "$DYLD_LIBRARY_PATH" = "" ]; then
  export DYLD_LIBRARY_PATH=$FDSBINDIR/openmpi/lib
else
  export DYLD_LIBRARY_PATH=$FDSBINDIR/openmpi/lib:$DYLD_LIBRARY_PATH
fi
export TMPDIR=/tmp
export OMP_NUM_THREADS=4

Additionally, line 1 is missing the exclamation mark in the shebang (#/bin/bash instead of #!/bin/bash).

It should also be checked whether SMV6VARS.sh contains the same issue (== instead of =)

[rmcdermo]

Thanks @gjaeger , we will get on fixing it asap. We all use bash. So, zsh is a gap in our workflow we need to fix.

[rmcdermo]

@gjaeger I trust you have thing working manually on your end in terms of using v6.11.1 of the code, though, correct?

[gjaeger]

@rmcdermo The suggested fix works for me with zsh as my default shell.

[rmcdermo]

@gjaeger Hi Gregor. Can you please check to see if the latest nightly bundle install works for you? I am not sure where this issue stands. Thanks

https://github.com/firemodels/test_bundles/releases/tag/FDS_TEST

[gforney]

Note the mac bundles are currently not being built. Hopefully this will be fixed next week