Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR creation is restricted, so this review PR is hosted in the fork. Its base matches
google/axmain.UpdateTaskStatus currently overwrites an entire stale task snapshot. Protect the read and write with WATCH/MULTI and bounded retries so a concurrent spec edit survives. Status publication occurs only with a successful transaction. Normalize an omitted atespace before selecting the key.
Fixes google#352.
TDD and validation
This branch starts independently from
origin/main(d8ed0fe) and has two commits:281c488adds the regression and fails on the original behavior.3ad3d2dimplements the fix; the regression and complete suite pass.Reproduce the red/green transition by checking out either commit and running:
Validated:
go test ./... -count=1, targeted-racetests,go mod tidywith unchanged module files,make build, andgit diff --check. Redis tests launch isolated real servers;redis-serveris installed in CI and documented for local development.Review
Codex review: no actionable regressions identified. Some reviewer test runs were blocked by its listener sandbox; the validation above was run separately with local listener access.