Repository navigation
fix off_m/off_n error in bli_gemm_ker_var2 - #959
Open
stepannassyr wants to merge 1 commit into
Open
stepannassyr wants to merge 1 commit into
stepannassyr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bli_auxinfo_set_off_m() is used twice when setting the offset into the C matrix.
As discussed in Discord, this seems to be a typo or a copy+paste error - the second one should be bli_auxinfo_set_off_n().
I've looked through the other macrokernels and I don't see these functions being used anywhere else, so I think it's really just this one line.