Skip to content

oem: add outscale support - #4288

Merged
tormath1 merged 8 commits into
mainfrom
tormath1/outscale
Nov 10, 2026
Merged

tormath1 merged 8 commits into
mainfrom
tormath1/outscale

Conversation

@tormath1

@tormath1 tormath1 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

In this PR, we provide Flatcar Outscale support. This pull Ignition 2.28.0 for Outscale support and a downstream patch for Afterburn (merged upstream but not released):

According to Outscale documentation, it seems we need to import qcow2 compressed image: https://docs.outscale.com/en/userguide/Manifest-File-Reference.html

Related to: flatcar/Flatcar#2334

Testing done

Successfully tested on Outscale: flatcar/Flatcar#2334 (comment)

This needs:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The OEM sysext is undiscoverable in its current path, and Afterburn activation conditions do not match the generated GRUB arguments.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity · 1 Low severity

Open (2)
What changed in this PR

Adds Flatcar Outscale support across image generation, OEM metadata, Ignition, Afterburn, hostname, and SSH-key provisioning.

Changes:

  • Adds Outscale Ignition and Afterburn provider patches.
  • Registers compressed qcow2 image generation and OEM configuration.
  • Adds Outscale boot-time metadata integrations.
File Summary
sdk_container/​src/​third_party/​coreos-overlay/​sys-kernel/​bootengine/​bootengine-0.0.38-r50.ebuild Bootengine package definition.
sdk_container/​src/​third_party/​coreos-overlay/​sys-apps/​ignition/​ignition-2.27.0-r1.ebuild Ignition package definition.
sdk_container/​src/​third_party/​coreos-overlay/​coreos/​user-patches/​sys-kernel/​bootengine/​0001-hostname-set-hostname-from-Outscale-metadata.patch Adds Outscale hostname handling.
sdk_container/​src/​third_party/​coreos-overlay/​coreos/​user-patches/​sys-apps/​ignition/​2296.patch Adds the Ignition Outscale provider.
sdk_container/​src/​third_party/​coreos-overlay/​coreos/​user-patches/​coreos-base/​coreos-init/​0001-sshkeys-add-Outscale-support.patch Adds Outscale SSH-key handling.
sdk_container/​src/​third_party/​coreos-overlay/​coreos/​user-patches/​coreos-base/​afterburn/​1297.patch Adds the Afterburn Outscale provider; hostname and SSH-key activation conditions require correction.
sdk_container/​src/​third_party/​coreos-overlay/​coreos-base/​oem-oraclecloud/​oem-outscale-0.ebuild Defines the Outscale OEM sysext; it must be moved to the Outscale directory and accompanied by a changelog entry.
sdk_container/​src/​third_party/​coreos-overlay/​coreos-base/​coreos-init/​coreos-init-0.0.1-r209.ebuild CoreOS init package definition.
sdk_container/​src/​third_party/​coreos-overlay/​coreos-base/​afterburn/​files/​coreos-metadata.service Enables the metadata service.
sdk_container/​src/​third_party/​coreos-overlay/​coreos-base/​afterburn/​afterburn-5.10.0-r4.ebuild Afterburn package definition.
build_library/​vm_image_util.sh Registers Outscale image generation.
build_library/​oem/​outscale/​grub.cfg Sets the Outscale OEM identifier.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.


EAPI=8

DESCRIPTION="OEM suite for Outscale"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Outscale images use unsupported compression, and required changelog entries are missing.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity · 1 Low severity

Open (2)
Resolved since last review (1)

Comment thread build_library/vm_image_util.sh Resolved
Copilot AI review requested due to automatic review settings September 21, 2026 14:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Add the required changelog entry for the user-facing Outscale support.

Review effort: Lite
Findings: 1 High severity · 1 Low severity

Open (2)

Copilot AI lite review requested due to automatic review settings November 9, 2026 13:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Several critical issues remain, including stale distfile manifests and patches that would fail or be applied twice to live ebuilds, so the change is not yet verifiable or buildable.

7 open issues

Review effort: Lite

@@ -0,0 +1,334 @@
From 716b1359dbfb40334c631681d53dbf18be78979f Mon Sep 17 00:00:00 2001
@@ -0,0 +1,97 @@
From 15704d0fe341605f97d978c5e8ca9fee8edf5aa0 Mon Sep 17 00:00:00 2001
inherit git-r3
else
EGIT_VERSION="7727ec78da72e700e8fa1ce2144cb2476448d186" # flatcar-master
EGIT_VERSION="d22a111e9c703c94f4e92466c37d2665a937c702" # flatcar-master
ConditionKernelCommandLine=|ignition.platform.id=ibmcloud
ConditionKernelCommandLine=|ignition.platform.id=kubevirt
ConditionKernelCommandLine=|ignition.platform.id=oraclecloud
+ConditionKernelCommandLine=|ignition.platform.id=outscale
Comment on lines +1 to +4
From 716b1359dbfb40334c631681d53dbf18be78979f Mon Sep 17 00:00:00 2001
From: Mohammad AMLA <mohammad.amla@numspot.com>
Date: Wed, 12 Aug 2026 17:11:31 +0200
Subject: [PATCH] providers: Add Outscale support
Copilot AI lite review requested due to automatic review settings November 9, 2026 13:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot AI lite review requested due to automatic review settings November 9, 2026 16:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An active moderate issue prevents approval because the Outscale image is generated with the wrong extension for direct import, and the change also lacks a release-note entry for the new platform.

8 open issues

Review effort: Lite

Comment thread build_library/vm_image_util.sh Resolved
Copilot AI lite review requested due to automatic review settings November 9, 2026 22:11
@tormath1
tormath1 marked this pull request as ready for review November 9, 2026 22:11
@tormath1
tormath1 requested a review from a team as a code owner November 9, 2026 22:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chewi chewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Copilot's suggestion to add IMG_outscale_DISK_EXTENSION=qcow2 is valid, but good other than that.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
All patches applied correctly - thanks to regular updates.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Copilot AI lite review requested due to automatic review settings November 10, 2026 16:32
@tormath1

Copy link
Copy Markdown
Contributor Author

IMG_outscale_DISK_EXTENSION=qcow2

Thanks - I dropped the arm64 support as well as it does not exist on Outscale: flatcar/Flatcar#2334 (comment)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tormath1
tormath1 merged commit add558c into main Nov 10, 2026
2 of 3 checks passed
@tormath1
tormath1 deleted the tormath1/outscale branch November 10, 2026 16:37
@github-project-automation github-project-automation Bot moved this from ✅ Testing / in Review to Implemented in Flatcar tactical, release planning, and roadmap Nov 10, 2026

This branch is waiting to be deployed

1 waiting deployment
development — 0fbc433f Waiting Nov 10, 2026 by tormath1 via Wait for approval #6116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

3 participants