Conversation
Move the create, edit and delete dialogs out of the index controllers into `api-key-actions` and `webhook-actions` services extending ember-core's `ResourceActionService`. The controllers now delegate to them, so behavior is unchanged. This lets other engines (the AI extension in particular) open the Developers dialogs through `universe.getServiceFromEngine` instead of query-param deep links.
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The API key and webhook dialogs lived inside the
api-keysandwebhooksindex controllers, so nothing outside those routes could open them. The Fleetbase AI extension needs to open them from the AI panel on any page, and query-param deep links were rejected as the mechanism.What
api-key-actionsservice (createApiKey,editApiKey, expiration options, test-mode handling) andwebhook-actionsservice (loadWebhookOptionsfor events, versions and credentials, plus create, edit and delete), both extending ember-core'sResourceActionService.universe.getServiceFromEngine('@fleetbase/dev-engine', 'api-key-actions')can reach them.Testing
Lint is clean and the build succeeds. The dialogs have not been clicked through in a browser yet — worth doing for New API Key, editing a key, and New Webhook before merge.
Related
Part of the Fleetbase AI audit; iam-engine gets the same treatment for users, groups, roles and policies.