You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After increasing the upload limit here in #32 and uploading a 19MB log, the page that displays it causes the browser to use 100% CPU and slows it to a crawl.
See: https://flightlessmango.com/games/14903/logs/1119
We need some optimization in the way data is displayed.
* reduce the amount of data (you could do this yourself by setting a higher `log_interval`)
This is an okay solution for those who know about what they're doing.
* we don't have an interactive graph anymore, we generate a static image instead
We could have a toggle on the page between interactive graphs and static images. The default would be interactive for a reasonably sized log. Anything above that value should default to static images. Mousing over the toggle will display a CPU usage and responsiveness warning.
* we limit the permitted size of log files
If we resort to the above solution, we don't have to limit the upload size.
Activity
flightlessmango commentedon Nov 16, 2020
I don't think it's reasonably possible to have this much data on an interactive graph.
A few options off the top of my head
log_interval)txtsd commentedon Nov 16, 2020
This is an okay solution for those who know about what they're doing.
We could have a toggle on the page between interactive graphs and static images. The default would be interactive for a reasonably sized log. Anything above that value should default to static images. Mousing over the toggle will display a CPU usage and responsiveness warning.
If we resort to the above solution, we don't have to limit the upload size.
flightlessmango commentedon Nov 16, 2020
I think static image (and also having option for interactive) is the way, but I'm not sure how to make the static images automatically
txtsd commentedon Nov 17, 2020
Unfortunately, I'm not familiar with ruby on rails. I could've helped if the backend was in python.