Updates impeller page to mention desktop compatibility. - #13635
Conversation
|
Staged preview of the updated docs.flutter.dev site (updated for commit 1cc6f91): https://flutter-docs-prod--docs-pr13635-desktop-impeller-9zql91kq.web.app |
|
Staged preview of the updated flutter.dev site (updated for commit 1cc6f91): https://flutter-dev-230821--www-pr13635-desktop-impeller-a3rfzx9l.web.app |
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Thanks for these updates @gaaclarke! Generally looks good to me, but can you add some additional context to the opt out instructions?
| Impeller is **available and enabled by default on Flutter 3.47**. In a future | ||
| release, the ability to opt-out of using Impeller will be removed. |
There was a problem hiding this comment.
"Opt out" doesn't need a hyphen when it's used as a verb:
| Impeller is **available and enabled by default on Flutter 3.47**. In a future | |
| release, the ability to opt-out of using Impeller will be removed. | |
| Impeller is **available and enabled by default as of Flutter 3.47**. | |
| In a future release, the ability to opt out of using Impeller will be removed. |
| Impeller is **available and enabled by default on Flutter 3.47**. In a future | ||
| release, the ability to opt-out of using Impeller will be removed. |
There was a problem hiding this comment.
| Impeller is **available and enabled by default on Flutter 3.47**. In a future | |
| release, the ability to opt-out of using Impeller will be removed. | |
| Impeller is **available and enabled by default as of Flutter 3.47**. | |
| In a future release, the ability to opt out of using Impeller will be removed. |
| Impeller is **available and enabled by default on Flutter 3.47**. In a future | ||
| release, the ability to opt-out of using Impeller will be removed. |
There was a problem hiding this comment.
| Impeller is **available and enabled by default on Flutter 3.47**. In a future | |
| release, the ability to opt-out of using Impeller will be removed. | |
| Impeller is **available and enabled by default as of Flutter 3.47**. | |
| In a future release, the ability to opt out of using Impeller will be removed. |
| To disable Impeller on Linux when deploying your app, add the following setup to | ||
| your project in `linux/runner/my_application.cc`. | ||
|
|
||
| ```c | ||
| fl_dart_project_set_enable_impeller(project, FALSE); | ||
| ``` |
There was a problem hiding this comment.
Can you add extra context on where in the file? Either by explaining it with prose or adding some of the surrounding code to the code block.
There was a problem hiding this comment.
Maybe:
g_autoptr(FlDartProject) project = fl_dart_project_new();
fl_dart_project_set_dart_entrypoint_arguments(project, self->dart_entrypoint_arguments);
+ fl_dart_project_set_enable_impeller(project, FALSE);| To disable Impeller on Windows when deploying your app, add the following setup to | ||
| your project in `windows\runner\main.cpp`. | ||
|
|
||
| ```c++ | ||
| project.set_impeller_switch(flutter::ImpellerSwitch::Disabled); | ||
| ``` |
There was a problem hiding this comment.
Can you add extra context on where in the file? Either by explaining it with prose or adding some of the surrounding code to the code block.
There was a problem hiding this comment.
Maybe:
flutter::DartProject project(L"data");
std::vector<std::string> command_line_arguments =
GetCommandLineArguments();
project.set_dart_entrypoint_arguments(std::move(command_line_arguments));
+ project.set_impeller_switch(flutter::ImpellerSwitch::Disabled);| To disable Impeller on Windows when deploying your app, add the following setup to | ||
| your project in `windows\runner\main.cpp`. | ||
|
|
||
| ```c++ |
There was a problem hiding this comment.
| ```c++ | |
| ```cpp |
4 participants
Do not land until 3.47 ships
Description of what this PR is changing or adding, and why:
This updates the impeller guidance to cover desktop compatibility.
Issues fixed by this PR (if any):
fixes flutter/flutter#190159
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.