Suppress redef warning of _CRT_SECURE_NO_WARNINGS if any. - #2218
Merged
Merged
Conversation
Suppress redef warning of _CRT_SECURE_NO_WARNINGS if any.
vitaut
reviewed
Apr 8, 2021
| @@ -6,7 +6,9 @@ | |||
| // For the license information refer to format.h. | |||
|
|
|||
| #ifdef WIN32 | |||
Contributor
There was a problem hiding this comment.
Let's get rid of the WIN32 check for simplicity. There is no harm in having the macro always defined.
Contributor
|
Thank you |
sthagen
added a commit
to sthagen/fmtlib-fmt
that referenced
this pull request
Apr 8, 2021
Suppress redef warning of _CRT_SECURE_NO_WARNINGS if any. (fmtlib#2218)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a pre-check of _CRT_SECURE_NO_WARNINGS before the def