Skip to content

cmake: hide private symbols by default - #2301

Merged
vitaut merged 1 commit into
fmtlib:masterfrom
sergiud:cmake-hide-private-symbols
May 21, 2021
Merged

vitaut merged 1 commit into
fmtlib:masterfrom
sergiud:cmake-hide-private-symbols

Conversation

@sergiud

@sergiud sergiud commented May 21, 2021

Copy link
Copy Markdown
Contributor

Enable -fvisibility=hidden and -fvisibility-inlines-hidden by default in CMakeLists.txt. Reduces the size of the shared library from 244K to 212K. Allow users to override the default choice.

Related to #2299.

@vitaut
vitaut merged commit 128cbde into fmtlib:master May 21, 2021
@vitaut

vitaut commented May 21, 2021

Copy link
Copy Markdown
Contributor

Thank you!

@sergiud
sergiud deleted the cmake-hide-private-symbols branch May 21, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants