exclude fallback functions when FMT_BUILTIN_CLZ(LL) is not defined - #2434
Merged
Merged
Conversation
Signed-off-by: Bodo Martin <bodo.martin@aci.uni-heidelberg.de>
vitaut
requested changes
Jul 25, 2021
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. LGTM but please address inline comments.
|
|
||
| // It is a separate function rather than a part of count_digits to workaround | ||
| // the lack of static constexpr in constexpr functions. | ||
| #ifdef FMT_BUILTIN_CLZLL |
Contributor
There was a problem hiding this comment.
Please move the #ifdef right before the comment:
#ifdef FMT_BUILTIN_CLZLL
// It is a separate function rather than a part of count_digits to workaround
// the lack of static constexpr in constexpr functions.
|
|
||
| // It is a separate function rather than a part of count_digits to workaround | ||
| // the lack of static constexpr in constexpr functions. | ||
| #ifdef FMT_BUILTIN_CLZ |
added 3 commits
July 25, 2021 17:14
Signed-off-by: Bodo Martin <bodo.martin@aci.uni-heidelberg.de>
vitaut
marked this pull request as ready for review
July 25, 2021 17:36
vitaut
approved these changes
Jul 25, 2021
Contributor
|
Thank you! |
PoetaKodu
pushed a commit
to pacc-repo/fmt
that referenced
this pull request
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial change to format.h to exclude fallback functions when FMT_BUILTIN_CLZ and FMT_BUILTIN_CLZLL
are not available. Happens to me on windows clangcl msvc codegen