Reuse tm_writer in other formatters - #2586
Merged
Merged
Conversation
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
November 6, 2021 16:15
98ac2e2 to
81350e1
Compare
Contributor
Author
|
Rebased |
Contributor
|
Thanks for another PR. It looks like the first commit only moves code around without changing functionality so could you move it to a separate PR to simplify reviewing this one? |
Merged
Contributor
Author
|
Yes. To use |
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
November 11, 2021 13:12
81350e1 to
1d756f7
Compare
Contributor
Author
|
@vitaut , PR updated. |
vitaut
requested changes
Nov 12, 2021
phprus
force-pushed
the
chrono-reuse-tm-1
branch
2 times, most recently
from
November 12, 2021 18:02
9a987ac to
c7abf2c
Compare
Contributor
Author
|
Waiting for #2594 ... |
phprus
marked this pull request as draft
November 12, 2021 19:29
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
November 12, 2021 21:04
c7abf2c to
e32ba3c
Compare
phprus
marked this pull request as ready for review
November 12, 2021 21:16
Contributor
Author
|
@vitaut, PR updated. |
vitaut
reviewed
Nov 12, 2021
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
November 12, 2021 21:24
e32ba3c to
6ee9334
Compare
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
November 13, 2021 17:52
6ee9334 to
3c5c0d8
Compare
Contributor
Author
|
@vitaut, PR updated. |
vitaut
requested changes
Nov 14, 2021
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
November 14, 2021 14:51
3c5c0d8 to
13705c0
Compare
vitaut
approved these changes
Nov 14, 2021
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All locale-dependent formatting is now in the
tm_writerclass.