Restore FMT_API on error_handler::on_error() - #2696
Merged
Merged
Conversation
this fixes a breaking ABI change that was introduce in the upgrade from 8.0.1 to 8.1.0. Fixes fmtlib#2695.
saraedum
added a commit
to saraedum/fmt-feedstock
that referenced
this pull request
Jan 4, 2022
saraedum
added a commit
to saraedum/fmt-feedstock
that referenced
this pull request
Jan 4, 2022
as in fmtlib/fmt#2696 fixes conda-forge#27
saraedum
added a commit
to saraedum/admin-requests
that referenced
this pull request
Jan 4, 2022
fmt-8.1.0 introduced a breaking ABI change. This breaks packages that were built against fmt-8.0.1 when they use fmt-8.1.0 at runtime. The issue has been reported upstream and a patch is waiting to be merged. We might create a patched 8.1.0 build or wait for 8.1.1; the relevant discussion is at conda-forge/fmt-feedstock#28 and fmtlib/fmt#2696. Pinning of fmt is handled by the conda-forge-pinning-feedstock.
saraedum
added a commit
to saraedum/admin-requests
that referenced
this pull request
Jan 4, 2022
fmt-8.1.0 introduced a breaking ABI change. This breaks packages that were built against fmt-8.0.1 when they use fmt-8.1.0 at runtime. The issue has been reported upstream and a patch is waiting to be merged. We might create a patched 8.1.0 build or wait for 8.1.1; the relevant discussion is at conda-forge/fmt-feedstock#28 and fmtlib/fmt#2696. An alternative here would be to patch the repodata and tell the <8.1.0 build to use !=8.1.0_0. However, it does not seem to be the correct approach to me to exclude a single build with a constraint.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes a breaking ABI change that was introduce in the upgrade from
8.0.1 to 8.1.0.
Fixes #2695.