Replace make_args_checked with make_format_args - #2760
Merged
Merged
Conversation
vitaut
requested changes
Feb 13, 2022
phprus
force-pushed
the
issue-2746-make_format_args
branch
from
February 13, 2022 16:19
2137e17 to
bdfec1d
Compare
Contributor
Author
|
@vitaut done |
vitaut
approved these changes
Feb 14, 2022
Zopolis4
pushed a commit
to Zopolis4/dolphin
that referenced
this pull request
Jun 14, 2022
make_args_checked is deprecated see fmtlib/fmt#2760 and the linked comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
make_args_checkedwithmake_format_argsand remove legacymake_args_checked.See: #2746 (comment)
@vitaut, please review these changes. I am not sure of their correctness.