You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Therefore, when compiling test-main, the macro FMT_API resolved to nothing, so test-main didn't know it had to import existing symbols (such as fmt::file::file() and others) and instead re-defined these symbols.
Later, when compiling a test (for exemple, os-test.cc), the test does depend on fmt, so it inherits FMT_SHARED, so FMT_API resolves to __declspec(dllimport), so it correctly imports the symbols from the fmt shared lib, which conflicts with the redefined symbols in test-main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix #2796 by exporting the whole class
fmt::v8::fileinstead of exporting all its individual member functions.I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.