Add xchar support for write_escaped_string. - #2904
Merged
Merged
Conversation
Merged
phprus
marked this pull request as draft
May 22, 2022 19:14
phprus
force-pushed
the
ranges-xchar-1
branch
3 times, most recently
from
May 22, 2022 19:56
cc85396 to
474f12f
Compare
phprus
marked this pull request as ready for review
May 22, 2022 20:03
vitaut
reviewed
May 27, 2022
| if (is_utf8()) { | ||
| if (escape.cp < 0x100) { | ||
| return format_to(out, FMT_STRING("\\x{:02x}"), escape.cp); | ||
| return write_codepoint<2>(out, static_cast<Char>('x'), escape.cp); |
Contributor
There was a problem hiding this comment.
Let's pass prefix as char to have the cast in one place (write_codepoint) instead of each call site.
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
vitaut
approved these changes
May 27, 2022
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
xcharsupport forwrite_escaped_string.