Conversation
vitaut
reviewed
May 27, 2022
Comment on lines
+3
to
+5
| if(NOT TARGET fmt::fmt) | ||
| include(${CMAKE_CURRENT_LIST_DIR}/@targets_export_name@.cmake) | ||
| endif() |
Contributor
There was a problem hiding this comment.
Please follow coding conventions:
if (NOT TARGET fmt::fmt)
include(${CMAKE_CURRENT_LIST_DIR}/@targets_export_name@.cmake)
endif ()
kieselnb
force-pushed
the
cmake-allow-find-package-after-add-subdirectory
branch
from
May 27, 2022 15:09
31697cb to
238b946
Compare
kieselnb
force-pushed
the
cmake-allow-find-package-after-add-subdirectory
branch
from
May 27, 2022 15:11
238b946 to
afdc039
Compare
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
find_package(fmt)to succeed if fmt is included in a project viaadd_subdirectory. This can help projects that want to support using either a system install or an in-tree package of fmt.