Improve CI on Windows, deprecate AppVeyor

[dimztimz]

Improve CI on Windows, deprecate AppVeyor. Fixes #3004.

[dimztimz]

This is ready. After this open the AppVeyor website and remove this repo from there. Hopefully, that should automatically remove the webhook, if not remove it manually from Github settings.

[vitaut]

Thanks for the PR. Looks great but please keep the old include/exclude rules and add one more include rule for the new config to keep them manageable.

[dimztimz]

Just so you know in the old rules the one entry in include with shared

fmt/.github/workflows/windows.yml

Lines 20 to 24 in 0b2862a

	include:
	- os: windows-2019
	platform: Win32
	build_type: Debug
	shared: -DBUILD_SHARED_LIBS=ON

was not adding a new job but was overriding an existing job generated by the build matrix above.

How about this: test toolset v140 (VS2015) only with standard C++14, v141 (VS2017) only with standard C++17 and toolset v142 with 2 standards, 17 and 20.

Win32 will get only 4 entries: (static, shared) x (debug, release) with the latest v142 toolchain.
on x64 shared will get only 2 entries with the latest toolchain with standard 17.

[dimztimz]

The build matrix that I pushed now generates 15 entries on Windows which is very much acceptable and manageable. There might be simpler rules that generate the same entries but I don't see them right now. Please review then in the view for Github Actions.

It even detected a build failure. Maybe with some recent changes, because I also rebased this on top of master.

[vitaut]

The failure in https://github.com/fmtlib/fmt/runs/7591983742?check_suite_focus=true seems related to #2957. cc @Dani-Hub

[phprus]

@dimztimz, @vitaut
Workaround commit: phprus@af72c41 (Branch: https://github.com/phprus/fmt/tree/ranges-msvc-1).

[dimztimz]

I will cherry-pick that and put it in this PR as separated commit. Also I will clean my commits.

[dimztimz]

I think this PR is in better shape now, it has two commits. I removed the commit that removes AppVeyor files to get the green check mark. You can remove them after you disable it from the settings.

[vitaut]

Thanks @dimztimz and @phprus!

[vitaut]

@dimztimz I just noticed that v140 build still reports MSVC 2019, not 2015:

-- Building for: Visual Studio 16 2019
-- CMake version: 3.23.2
-- The CXX compiler identification is MSVC 19.0.24245.0

(https://github.com/fmtlib/fmt/runs/7632834167?check_suite_focus=true)

Do you know why?

[phprus]

It's Ok.

-- Building for: Visual Studio 16 2019
-- CMake version: 3.23.2
-- The CXX compiler identification is MSVC 19.0.24245.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe - skipped

Visual Studio - 2019
MSVC - 19.0.24245.0 (toolset from Visual Studio 2015)

[vitaut]

What a versioning mess =). Where did you find the info that 19.0.24245.0 corresponds to 2015?

[phprus]

See _MSC_VER value on page https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170

[dimztimz]

https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering

It is total mess. There are like four different versions. One is year, one is IDE version, one is toolset version and the last is compiler version. Roughly:

• toolset v14.0x = compiler v19.0x.
• toolset v14.1x = compiler v19.1x.
• toolset v14.2x = compiler v19.2x.