Skip to content

Fix testsuite on MinGW + MSVCRT - #3029

Merged
vitaut merged 2 commits into
fmtlib:masterfrom
dimztimz:mingw
Aug 14, 2022
Merged

vitaut merged 2 commits into
fmtlib:masterfrom
dimztimz:mingw

Conversation

@dimztimz

@dimztimz dimztimz commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

Fixes #2952. The testsuite indirectly called strftime() with conversion specifiers defined only in C99. In MSVCRT this function conforms only to C89. Only in the updated UCRT this functon provides the functionality of C99.

@vitaut vitaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment thread test/chrono-test.cc Outdated
Fixes #2952. The testsuite indirectly called strftime() with conversion
specifiers defined only in C99. In MSVCRT this function conforms only to
C89. Only in the updated UCRT this functon provides the functionality of
C99.
@vitaut
vitaut merged commit fd41110 into fmtlib:master Aug 14, 2022
@vitaut

vitaut commented Aug 14, 2022

Copy link
Copy Markdown
Contributor

Merged, thanks!

@dimztimz
dimztimz deleted the mingw branch September 8, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing tests on MSYS2/MinGW x64

2 participants