Skip to content

Move formatter<std::error_code> from fmt/os.h to fmt/std.h - #3125

Merged
vitaut merged 1 commit into
fmtlib:masterfrom
phprus:format-error_code-2
Oct 2, 2022
Merged

vitaut merged 1 commit into
fmtlib:masterfrom
phprus:format-error_code-2

Conversation

@phprus

@phprus phprus commented Oct 1, 2022

Copy link
Copy Markdown
Contributor

Issue: #3123

Comment thread test/std-test.cc Outdated
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus
phprus force-pushed the format-error_code-2 branch from 0d55cef to 720f562 Compare October 1, 2022 22:03
@vitaut
vitaut merged commit 662adf4 into fmtlib:master Oct 2, 2022
@vitaut

vitaut commented Oct 2, 2022

Copy link
Copy Markdown
Contributor

Thank you!

@tupaschoal

Copy link
Copy Markdown
Contributor

Should this PR also have touched documentation for std.h? It currently does not say that it provides formatting for error_code, just:

fmt/std.h provides formatters for:

[std::filesystem::path](https://en.cppreference.com/w/cpp/filesystem/path)

[std::thread::id](https://en.cppreference.com/w/cpp/thread/thread/id)

[std::monostate](https://en.cppreference.com/w/cpp/utility/variant/monostate)

[std::variant](https://en.cppreference.com/w/cpp/utility/variant/variant)

[std::optional](https://en.cppreference.com/w/cpp/utility/optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants