Fix broken condition - #3129
Merged
Merged
Fix broken condition#3129
Conversation
Contributor
|
Good catch, thanks. Let's keep it a normal condition instead of |
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
phprus
force-pushed
the
gcc-version-wa-1
branch
from
October 7, 2022 12:29
844fd7f to
ad75e88
Compare
Contributor
Author
|
@vitaut |
Contributor
|
Should this condition be wrapped with const_check?
…On Fri, Oct 7, 2022, 05:44 Vladislav Shchapov ***@***.***> wrote:
@vitaut <https://github.com/vitaut>
Fixed.
—
Reply to this email directly, view it on GitHub
<#3129 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIID32AZDQVIDPP5GCBGBDWCALKNANCNFSM6AAAAAAQ6737XA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
I don't think so. |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FMT_GCC_VERSION >= 1200equal to false for all non GCC compilers.But this condition was added as a workaround for the GCC bug: #3128.