Skip to content

Formatting of system clocks ought to be to UTC, not to local time. - #3230

Closed
ned14 wants to merge 1 commit into
fmtlib:masterfrom
ned14:master
Closed

ned14 wants to merge 1 commit into
fmtlib:masterfrom
ned14:master

Conversation

@ned14

@ned14 ned14 commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

This improves standards conformance of fmt.

#3199

This improves standards conformance of fmt.
@vitaut

vitaut commented Dec 17, 2022

Copy link
Copy Markdown
Contributor

Thanks for the PR! Overall looks good but please fix the compilation error: https://github.com/fmtlib/fmt/actions/runs/3715176616/jobs/6310218797.

@vitaut

vitaut commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

Merged with one fix in 115001a. Note that local_system_clock_time_point is still broken on Windows and therefore temporarily disabled. Another PR to fix it would be welcome.

@vitaut vitaut closed this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants