Skip to content

Unification utf16/utf32 to utf8 conversion - #3416

Merged
vitaut merged 2 commits into
fmtlib:masterfrom
phprus:unicode-1
May 6, 2023
Merged

vitaut merged 2 commits into
fmtlib:masterfrom
phprus:unicode-1

Conversation

@phprus

@phprus phprus commented May 2, 2023

Copy link
Copy Markdown
Contributor

Discussion: 02cae7e#r111229765

XCode 14.3 error (fix in first commit):

cd /Users/phprus/Devel/fmt/build/cxx17/test && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DGTEST_HAS_STD_WSTRING=1 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING=1 -I/Users/phprus/Devel/fmt/include -isystem /Users/phprus/Devel/fmt/test/gtest/. -O2 -g -DNDEBUG -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -pedantic -Wconversion -Wundef -Wdeprecated -Wweak-vtables -Wshadow -Wno-gnu-zero-variadic-macro-arguments -Wzero-as-null-pointer-constant -Werror -std=gnu++17 -MD -MT test/CMakeFiles/gtest-extra-test.dir/gtest-extra-test.cc.o -MF CMakeFiles/gtest-extra-test.dir/gtest-extra-test.cc.o.d -o CMakeFiles/gtest-extra-test.dir/gtest-extra-test.cc.o -c /Users/phprus/Devel/fmt/test/gtest-extra-test.cc
/Users/phprus/Devel/fmt/test/gtest-extra-test.cc:203:7: error: variable 'n' set but not used [-Werror,-Wunused-but-set-variable]
  int n = 0;
      ^
/Users/phprus/Devel/fmt/test/gtest-extra-test.cc:215:7: error: variable 'n' set but not used [-Werror,-Wunused-but-set-variable]
  int n = 0;
      ^
2 errors generated.

phprus added 2 commits May 3, 2023 20:37
…but-set-variable]

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus

phprus commented May 3, 2023

Copy link
Copy Markdown
Contributor Author

Rebased.

@vitaut
vitaut merged commit dde8cf3 into fmtlib:master May 6, 2023
@vitaut

vitaut commented May 6, 2023

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants