Fix deprecation warning in libc++ (LLVM-16) - #3634
Merged
Merged
Conversation
vitaut
requested changes
Sep 16, 2023
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. A few comments inline.
| # ifdef _LIBCPP_VERSION | ||
| namespace std { | ||
|
|
||
| template <> struct char_traits<custom_char> { |
Contributor
There was a problem hiding this comment.
Does the standard permit user specializations of char_traits?
Contributor
Author
There was a problem hiding this comment.
https://en.cppreference.com/w/cpp/string/char_traits:
The char_traits class template serves as a basis for explicit instantiations. The user can provide a specialization for any custom character types. Several explicit specializations are provided for the standard character types (see below), other specializations are not required to satisfy the requirements of CharTraits.
vitaut
reviewed
Sep 17, 2023
phprus
force-pushed
the
llvm-1
branch
2 times, most recently
from
September 17, 2023 15:52
4887c24 to
7bf9899
Compare
…or T not equal to char, wchar_t, char8_t, char16_t or char32_t is non-standard and is provided for a temporary period. It will be removed in LLVM 18, so please migrate off of it. [-Werror,-Wdeprecated-declarations] Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
vitaut
approved these changes
Sep 18, 2023
Contributor
|
Thank you! |
ckerr
pushed a commit
to transmission/fmt
that referenced
this pull request
Nov 7, 2023
…or T not equal to char, wchar_t, char8_t, char16_t or char32_t is non-standard and is provided for a temporary period. It will be removed in LLVM 18, so please migrate off of it. [-Werror,-Wdeprecated-declarations] (fmtlib#3634) Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning:
LLVM source:
https://github.com/llvm/llvm-project/blob/7cbf1a2591520c2491aa35339f227775f4d3adf6/libcxx/include/__string/char_traits.h#L74-L80