Fix include xlocale - #3699
Closed
hotwatermorning wants to merge 3 commits into
Closed
Fix include xlocale#3699hotwatermorning wants to merge 3 commits into
hotwatermorning wants to merge 3 commits into
Conversation
vitaut
reviewed
Nov 2, 2023
|
|
||
| #if defined __APPLE__ || defined(__FreeBSD__) | ||
| # include <xlocale.h> // for LC_NUMERIC_MASK on OS X | ||
| # if (__cplusplus < 201703L) || __has_include(<xlocale.h>) |
Contributor
There was a problem hiding this comment.
Please use FMT_HAS_INCLUDE(<xlocale.h>) instead of these checks.
Contributor
Author
There was a problem hiding this comment.
@vitaut Hi, I changed the code to use FMT_HAS_INCLUDE and rebased on origin's master.
hotwatermorning
force-pushed
the
fix-include-xlocale
branch
from
November 2, 2023 17:45
1ca3f28 to
b345027
Compare
vitaut
approved these changes
Nov 2, 2023
Contributor
|
Merged with a minor tweak, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use fmtlib's fmt on some console game development environment, but os.h doesn't compile because of missing of xlocale.h.
Therefore I added
__has_include()check before including xlocale.h.Thanks.