Skip to content

Fix chrono locale format bug for RHEL gcc - #3859

Merged
vitaut merged 2 commits into
fmtlib:masterfrom
g199209:master
Feb 25, 2024
Merged

vitaut merged 2 commits into
fmtlib:masterfrom
g199209:master

Conversation

@g199209

@g199209 g199209 commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

Fix #3858

Fix fmtlib#3858

Signed-off-by: Gao Mingfei <gaomingfei@mdsl-invest.com>
@phprus

phprus commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

This is a bug in the devtoolset architecture.
devtoolset claims the features of the new libstdc++, but does not fully implement them.
Unfortunately, there is no easy way to determine whether devtoolset is being used.

We need to check your patch in SUSE Enterprise Linux 12 or in openSUSE Leap 42.3 (with forced activation of OLD and NEW ABI modes). Base compiler in SUSE 12 - gcc 4.8, and SUSE 12 provide new gcc (5,6,7) (with OLD and NEW ABI).

@vitaut vitaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do additional testing per comment by @phprus.

@g199209

g199209 commented Feb 25, 2024

Copy link
Copy Markdown
Contributor Author

Please do additional testing per comment by @phprus.

I do not have such test enviroment.

@phprus

phprus commented Feb 25, 2024

Copy link
Copy Markdown
Contributor

@vitaut
I tested it.
Fix is ok.

@vitaut
vitaut merged commit ebea573 into fmtlib:master Feb 25, 2024
happymonkey1 pushed a commit to happymonkey1/fmt that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chrono locale format code has some bug when using RHEL gcc on CentOS 7.6 to compile

3 participants