Skip to content

Fix warnings from MSVC - #3933

Closed
jimmy-park wants to merge 3 commits into
fmtlib:masterfrom
jimmy-park:fix-msvc-warnings
Closed

jimmy-park wants to merge 3 commits into
fmtlib:masterfrom
jimmy-park:fix-msvc-warnings

Conversation

@jimmy-park

Copy link
Copy Markdown
Contributor

Following warnings are detected by MSVC Code Analysis.

  • C26439 : This kind of function may not throw. Declare it noexcept.
  • C26495 : Variable is uninitialized. Always initialize a member variable (type.6).
  • C26498 : The function is constexpr, mark variable constexpr if compile-time evaluation is desired (con.5).

@vitaut

vitaut commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

Thanks for the PR. The move ctor noexcept change makes sense: merged in f4b256c. The other analysis warnings are mostly noise and can be ignored.

@vitaut vitaut closed this Apr 19, 2024
@jimmy-park
jimmy-park deleted the fix-msvc-warnings branch April 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants