Skip to content

Fix FMT_USE_NONTYPE_TEMPLATE_ARGS define back - #3937

Merged
vitaut merged 1 commit into
fmtlib:masterfrom
Arghnews:FixDefine
Apr 16, 2024
Merged

vitaut merged 1 commit into
fmtlib:masterfrom
Arghnews:FixDefine

Conversation

@Arghnews

@Arghnews Arghnews commented Apr 16, 2024

Copy link
Copy Markdown
Contributor

Broken in refactor f1924d3

From #3935 @timsong-cpp 's guess was right

Was:

#if
...
      ((FMT_GCC_VERSION >= 903 && FMT_CPLUSPLUS >= 201709L) || \
       __cpp_nontype_template_args >= 201911L) &&              \
...
#define FMT_USE_NONTYPE_TEMPLATE_ARGS 1

Became:

#elif FMT_GCC_VERSION >= 903 && FMT_CPLUSPLUS >= 201709L
#  define FMT_USE_NONTYPE_TEMPLATE_ARGS 0
#elif defined(__cpp_nontype_template_args) && \
    __cpp_nontype_template_args >= 201911L
#  define FMT_USE_NONTYPE_TEMPLATE_ARGS 1

Fix is to set back to previous

@vitaut
vitaut merged commit 9973576 into fmtlib:master Apr 16, 2024
@vitaut

vitaut commented Apr 16, 2024

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants