Skip to content

Suppress a bogus warning in MSVC - #4023

Merged
vitaut merged 1 commit into
fmtlib:masterfrom
phprus:msvc-cplusplus-2
Jun 19, 2024
Merged

vitaut merged 1 commit into
fmtlib:masterfrom
phprus:msvc-cplusplus-2

Conversation

@phprus

@phprus phprus commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

<source_location> and <ranges> is C++20 heades (FMT_CPLUSPLUS > 201703L), not C++17 (FMT_CPLUSPLUS >= 201703L).

Warnings:

The contents of <ranges> are available only with C++20 or later.
The contents of <source_location> are available only with C++20 consteval support.

@vitaut vitaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Comment thread include/fmt/std.h
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus
phprus force-pushed the msvc-cplusplus-2 branch from b20b9a6 to 3d879c8 Compare June 19, 2024 15:07
@vitaut
vitaut merged commit 514b695 into fmtlib:master Jun 19, 2024
@vitaut

vitaut commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants