make format_int constexpr - #4032
Merged
Merged
Conversation
vitaut
requested changes
Jun 22, 2024
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. Overall looks good but please apply clang-format.
vitaut
reviewed
Jun 22, 2024
|
|
||
| /// Returns the content of the output buffer as an `std::string`. | ||
| auto str() const -> std::string { return std::string(str_, size()); } | ||
| FMT_CONSTEXPR20 auto str() const -> std::string { |
Contributor
There was a problem hiding this comment.
Let's drop FMT_CONSTEXPR20 here since constexpr std::string is less widely available.
Contributor
Author
There was a problem hiding this comment.
ok, one can always write a constexpr free function for it (I did anyway)
vitaut
approved these changes
Jun 22, 2024
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.