Replace std::forward for clang-tidy - #4236
Merged
Merged
Conversation
Arghnews
force-pushed
the
fix_use_after_move_in_join_view
branch
from
November 14, 2024 08:05
03e1128 to
fa49e15
Compare
vitaut
approved these changes
Nov 14, 2024
Contributor
|
Merged, thanks! |
|
Thank you all! |
This was referenced Dec 25, 2024
This was referenced Mar 3, 2025
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #4231
Fix was a little different than I thought initially, due to trickiness of getting
constrightCould instead use
<!std::is_copy_constructible_v<It>, It&, It>;as of courseview_refis just dependent on this. I don't see or have a strong preference either way