Remove some redundant consts and inlines - #4445
Merged
Merged
Conversation
Contributor
|
Thanks for the PR. |
vitaut
requested changes
May 12, 2025
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Please revert the inline changes.
`constexpr` variables are implicitly `const`.
localspook
force-pushed
the
redundant-const-and-inline
branch
from
May 12, 2025 14:12
3486a43 to
85f285a
Compare
Contributor
Author
|
Wow, I was unaware of the module changes. I've read up on them now. Sorry for the delay, and sorry for the force-push; I couldn't wrangle git into reverting those lines in a new commit. |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
constexprvariables are implicitlyconst, and member functions defined within their class definition are implicitlyinline.