Give useful error when misusing fmt::ptr. - #4453
Merged
Merged
Conversation
static_assert(bla, "") prints an empty message but not the condition with at least MSVC. Add an informative message.
Contributor
|
Merged, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static_assert(bla, "") prints an empty message but not the condition with MSVC. Add an informative message.
E.g.
int i; fmt::print("{}", fmt::ptr(i))will print the empty message from the static_assert and the code location, but not the static_assert's condition. This patch makes it print a useful message.
I audited all static_asserts, and this appears to be the only user-facing static_assert that didn't contain a message.