Delete Bazel files - #4530
Merged
Merged
Delete Bazel files#4530
Conversation
Vertexwahn
approved these changes
Sep 3, 2025
fmeum
approved these changes
Sep 3, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel requires
BUILD.bazelfiles to be in-tree and aMODULE.bazelfile to mark the root folder of the module. Moving the Bazel support files to the appropriate place was denied in #4527.So the Bazel related files in the current folder are useless. Worse, they even actively break downstream packaging (for example when
BUILD.bazelloads from repositories not specified in the downstreamMODULE.bazelfile or when the paths to source files relative to theBUILD.bazelfile don't exist.Therefore, @Vertexwahn and myself agreed that it would be best to delete these files from this repository.