Skip to content

Fix write_significand buffer size to avoid GCC 16 LTO -Wstringop-overflow (#4767) #4957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MuskanKhatwani wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Fix write_significand buffer size to avoid GCC 16 LTO -Wstringop-overflow (#4767) #4957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/fmt/format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2654,8 +2654,9 @@ template <typename OutputIt, typename UInt, typename Char,
inline auto write_significand(OutputIt out, UInt significand,
int significand_size, int integral_size,
Char decimal_point) -> OutputIt {
// Buffer is large enough to hold digits (digits10 + 1) and a decimal point.
Char buffer[digits10<UInt>() + 2];
// Buffer is large enough to hold the full significand, a decimal point,
// and the extra slot used by the write path on GCC 16 with LTO.
Char buffer[digits10<UInt>() + 3];
auto end = write_significand(buffer, significand, significand_size,
integral_size, decimal_point);
return detail::copy_noinline<Char>(buffer, end, out);
Expand Down
Loading