Conversation
fontanf
added a commit
that referenced
this pull request
Sep 23, 2026
Picks up fontanf/shape#69, #70, #71, #72 and #73, which fix the failures of the irregular instance building reported in #595 and #598: - #69: the line-segment approximation of an arc placed on its circle ended with a degenerate segment, making circular holes look self-intersecting. - #70: the fallback union of that approximation used clockwise extras for anticlockwise arcs, filling holes. - #71, #72: line/circle and circle/circle tangencies were computed as two intersections a few micro-units apart, or as none, which made boolean operations fail ("face area is not positive") or overflow the stack. - #73: no_fit_polygon merged nearly parallel edges in the wrong order, so the self-NFPs used by the periodic packing were not exact (nor centrally symmetric), which made the lattice search unions fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.